Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save paperclip-16.svg, paperclip-24.svg #801

Merged
merged 10 commits into from
Jul 27, 2022
Merged

Save paperclip-16.svg, paperclip-24.svg #801

merged 10 commits into from
Jul 27, 2022

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Jun 29, 2022

Adds the new attachment icon using the paperclip metaphor.

attachment icons

@gavinmn gavinmn requested a review from a team as a code owner June 29, 2022 21:22
@gavinmn gavinmn requested a review from ashygee June 29, 2022 21:22
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 997e5e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis
Copy link
Contributor

colebemis commented Jun 29, 2022 •
edited
Loading

Looks great! Just curious, did you explore a rotated paperclip icon? Similar to this:

CleanShot 2022-06-29 at 14 23 27@2x

I wonder how the straight vs rotated versions compare when placed in context.

@gavinmn
Copy link
Contributor Author

gavinmn commented Jun 29, 2022

Looks great! Just curious, did you explore a rotated paperclip icon? Similar to this:

CleanShot 2022-06-29 at 14 23 27@2x

I wonder how the straight vs rotated versions compare when placed in context.

That's a good idea. I hadn't looked at that yet so we can hold of on merging this and I'll take a second look to see if it works better.

@gavinmn gavinmn temporarily deployed to github-pages June 29, 2022 21:26 Inactive
@gavinmn
Copy link
Contributor Author

gavinmn commented Jul 21, 2022

Revisited this icon exploring out the tilted variation:
attachment

I think this version is more distinct and makes better use of the horizontal space.

@gavinmn gavinmn changed the title Save attachment-16.svg, attachment-24.svg Save paperclip-16.svg, paperclip-24.svg Jul 21, 2022
@gavinmn gavinmn requested a review from colebemis July 21, 2022 18:25
@gavinmn gavinmn temporarily deployed to github-pages July 21, 2022 18:28 Inactive
@ashygee ashygee enabled auto-merge (squash) July 27, 2022 16:07
@ashygee ashygee temporarily deployed to github-pages July 27, 2022 16:32 Inactive
@ashygee ashygee merged commit 8e5dcfc into main Jul 27, 2022
@ashygee ashygee deleted the gavinmn/attachment branch July 27, 2022 16:36
@primer-css primer-css mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashygee ashygee ashygee approved these changes

@colebemis colebemis Awaiting requested review from colebemis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gavinmn @colebemis @ashygee @actions-user